On 03/11/15 13:49, Jeff Law wrote: > On 11/03/2015 04:31 AM, tbsaunde+...@tbsaunde.org wrote: >> From: Trevor Saunders <tbsaunde+...@tbsaunde.org> >> >> Hi, >> >> $subject, nothing refers to this header so we might as well remove it. >> >> tested I can still build on x86_64-linux-gnu, not that I would expect >> anything >> else or that it is particularly relevent, ok? >> >> Trev >> >> gcc/ChangeLog: >> >> 2015-11-03 Trevor Saunders <tbsaunde+...@tbsaunde.org> >> >> * config/arm/coff.h: Remove. > More generally, if we have a header file that's not used, I'd consider > removing it to be obvious-enough to commit without approval. > > We could/should probably do the same with unused functions, with the > only wrinkle being things that are useful for debugging but which are > otherwise unused should be kept around. >
I'd go as far as to say that such functions should be commented to that effect. R. > jeff >
