On Tue, Oct 27, 2015 at 07:03:40AM -0700, Nathan Sidwell wrote:
> On 10/27/15 06:45, Richard Biener wrote:
> >On Tue, Oct 27, 2015 at 9:03 AM, Jakub Jelinek <ja...@redhat.com> wrote:
>
> >>Ok for me, but please wait for Richi's ack too.
> >
> >+ /* An IFN_UNIQUE call must be duplicated as part of its group,
> >+ or not at all. */
> >+ if (is_gimple_call (g) && gimple_call_internal_p (g)
> >+ && gimple_call_internal_unique_p (g))
> >
> >&&s always to the next line
>
> oh, did not know that.
I believe the general rule is if all the conditions are short enough
that everything fits on a single line, you can write it as
if (a && b && c && d)
but as soon as you need to wrap, it should be one && per line, so
if (a
&& b
&& c
&& d)
style in that case rather than
if (a && b
&& c && d)
But, lots of code doesn't do it this way.
Jakub
