On Thu, Sep 03, 2015 at 01:36:35PM +0200, Sebastian Huber wrote:
> On 03/09/15 13:10, Jakub Jelinek wrote:
> >On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote:
> >>>>>We have only thread attributes in this function: mutable_attr and attr.
> >>>>>The
> >>>>>attr is initialized with &gomp_thread_attr and gomp_thread_attr is
> >>>>>supposed
> >>>>>to be read-only by this function. Under certain conditions we have to
> >>>>>modify
> >>>>>the initial attributes. Since gomp_thread_attr is read-only, we have to
> >>>>>copy
> >>>>>it and then modify the copy. For this we need some storage: mutable_attr.
> >>>So use local_thread_attr if you want to stress it, but IMHO thread_attr
> >>>just just fine. I really don't like mutable_attr.
> >>Ok, if I don't rename thread_attr, is the patch ok?
> >Yes.
>
> Thanks a lot for your kind review.
>
> I committed the patches as:
>
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227439
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227440
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227441
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227442
Unfortunately it broke stuff, here is a fix I've committed:
2015-09-03 Jakub Jelinek <ja...@redhat.com>
* configure.tgt: Add missing ;; in between nvptx and rtems
snippets.
--- libgomp/configure.tgt (revision 227456)
+++ libgomp/configure.tgt (working copy)
@@ -153,6 +153,7 @@ case "${target}" in
nvptx*-*-*)
config_path="nvptx"
+ ;;
*-*-rtems*)
# Use self-contained synchronization objects if provided by Newlib
Jakub
