On 10/08/15 10:43, Uros Bizjak wrote:
On Mon, Aug 10, 2015 at 11:36 AM, Kyrill Tkachov <kyrylo.tkac...@arm.com> wrote:
I'm testing a patch that fix the testcases on x86_64 and does not
harm codegen on aarch64. Feel free to file a PR and assign it to me.
PR67103 [1]
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103
Thanks,
Here's the patch to move that transformation from
noce_try_store_flag_constants
to noce_try_cmove after the target-specific expansion has had a go.
This fixes the testcases for me on x86_64.
In i386.exp I only see:
FAIL: gcc.target/i386/pr49781-1.c scan-assembler-not lea[lq]?[
\t]\\((%|)r[a-z0-9]*
FAIL: gcc.target/i386/pr61403.c scan-assembler blend
which were there before my patch.
Bootstrap and testing on x86_64, arm and aarch64 is successful for me.
Is this ok?
Ping.
Uros, does the codegen with this patch look ok to you?
Yes, the code of previously failing testcases looks OK.
You will need an approval from rtl-optimization maintainer, though.
Sure, thanks for confirming.
Kyrill
Uros.