-----Original Message-----
From: Oleg Endo [mailto:oleg.e...@t-online.de]
Sent: Monday, July 06, 2015 7:07 PM
To: Ajit Kumar Agarwal
Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida;
Nagaraju Mekala
Subject: Re: [Patch,microblaze]: Optimized usage of reserved stack space for
function arguments.
>>Hi,
>>Just some general comments...
Thanks.
On 06 Jul 2015, at 22:05, Ajit Kumar Agarwal <ajit.kumar.agar...@xilinx.com>
wrote:
> +static bool
> +microblaze_parm_needs_stack (cumulative_args_t args_so_far, tree
> +type) {
> + enum machine_mode mode;
^^^^
>> 'enum' is not required in C++, please omit it.
>> We've been trying to remove unnecessary 'struct' and 'enum' after the
>>switch to C++. Although there are still some of them around, please
>>don't add new ones.
Sure.
> + int unsignedp;
> + rtx entry_parm;
^^^^
>>Please declare variables at their first use.
>>(there are other such cases in your patch)
I have declared the above variables in the first scope of their first
use. Sorry, it's not clear to me.
You meant to say to declare in the following way.
int unsignedp = TYPE_UNSIGNED (type);
rtx entry_parm = microblaze_function_arg (args_so_far, mode, type, true);
Thanks & Regards
Ajit
Cheers,
Oleg
