Hi, Just some general comments...
On 06 Jul 2015, at 22:05, Ajit Kumar Agarwal <ajit.kumar.agar...@xilinx.com> wrote: > +static bool > +microblaze_parm_needs_stack (cumulative_args_t args_so_far, tree type) > +{ > + enum machine_mode mode; ^^^^ 'enum' is not required in C++, please omit it. We've been trying to remove unnecessary 'struct' and 'enum' after the switch to C++. Although there are still some of them around, please don't add new ones. > + int unsignedp; > + rtx entry_parm; ^^^^ Please declare variables at their first use. (there are other such cases in your patch) Cheers, Oleg