On Sun, Jul 05, 2015 at 07:48:13PM +0200, Paul Richard Thomas wrote: > Dear Andre, > > I agree with Steve's recommendation that you comment out the line and > open a PR for the problem. > > The patch looks fine to me and applied cleanly, apart from trailing > CRs in the testcases. > > OK by me too. > > Cheers > > Paul > > PS I felt safe in setting a deadline for the submodule patch because: > (i) It was obvious that nobody would review it because of its size; > and (ii) It is safely ring-fenced by the need for very specific > procedure attributes and declarations. I would not dream of doing the > same for other patches more integrated in parts of the compiler that > are frequented by commonly used code. For example, the patch to > encompass the use of private entities with submodules will be just > such a patch.... when I figure out how to do it! I can sympathize with > you though; you have often had to wait an excessively long time for > reviews. >
Fortunately (or unfortunately depends how one looks at the situation) Andre is working in an area that I feel very uncomfortable reviewing. I haven't ventured into OOP Fortran, and I'm still recovering from my last encounter with allocate/deallocate code. I also agree that waiting 6+ weeks for approval is a bit long time. Unfortunately, it seems evident that we're all too busy with Real Life(tm) at the moment. PS: Are you going to announce your submodule milestone on c.l.f? -- Steve
