On Mon, Jun 15, 2015 at 07:18:27PM +0300, Ilya Verbin wrote:
> On Mon, Jun 15, 2015 at 15:06:09 +0200, Jakub Jelinek wrote:
> > On Mon, Jun 15, 2015 at 03:20:37PM +0300, Ilya Verbin wrote:
> > > This patch introduces new versions of GOMP_target{,_data,_update} for
> > > OpenMP 4.1
> > > with unsigned short for map kinds, but without new async arguments yet.
> >
> > I think I'd prefer (for now) to suffix the functions with _41 instead of 1
> > (and we'll see if we can come up with better names when async support is
> > added).
>
> OK.
Thanks.
> > Do we need to change GOMP_target_update though (at least right
> > now)? I mean, the construct only allows to and from clauses, not the map
> > clause, and those don't really have an always modifier, nor release/delete
> > semantics etc., so at least for now I think using the current
> > GOMP_target_update should be ok.
>
> I thought that it wouldn't look good, since without GOMP_target_update_41 we
> will need to keep this obsolete parts:
I'd prefer to keep it for now, perhaps later on we'll switch to 16-bit kinds
even for that, but better figure out first what to do with the async stuff,
handle the enter/exit data correctly, change the library for OpenMP 4.1 to
do the fully refcounted model.
Jakub
