Hi,
On Thu, 11 Jun 2015 13:17:47 +0200, Eric Botcazou wrote:
>
>> Other than that, as I said already in the PR, I'm in favor of applying it to
>> the trunk (only, not release branches) and watching for performance and/or
>> wrong-code issues, but Eric is against it. What do others think about it?
>
> Yes, I'm against it, I think that the patch will introduce more issues, and on
> real-life software this time, than it fixes, but you just need to a second
> maintainer to overrule me.
>
I think I can say, my patch does not change the return value on
frame_pointer_rtx.
So that will stay as before (identical as with your patch).
BTW: meanwhile I found out, that all these 2930 accesses to frame_pointer_rtx
with positive
offset seem to happen in the reload pass. That's funny, because I think that
did not happen
when I looked at it the last time, and I do not yet understand why this happens
now.
The worst thing that can happen on the other base registers, would be a few
disabled
if conversions, on offsets that exceed the safety margins...
Of course, it would be good if some one with deeper insight than myself would
look at
the patch in detail if the assumptions are actually safe. I believe they are.
But one thing is sure, really nonsense values like 0xDEADBEEF will be outside
the margins,
and that is not the case right now.
Thanks
Bernd.
