> Other than that, as I said already in the PR, I'm in favor of applying it to > the trunk (only, not release branches) and watching for performance and/or > wrong-code issues, but Eric is against it. What do others think about it?
Yes, I'm against it, I think that the patch will introduce more issues, and on real-life software this time, than it fixes, but you just need to a second maintainer to overrule me. > From John Regehr's talk at GCC Summit a few years ago I got the > impression that for people to be able to effectively report bugs in the > compiler through code generator it is important that discovered bugs in the > compiler are fixed timely, otherwise it makes life to the reporters much > harder, because then they'll run into the same still unfixed issue all the > time. This one is very peculiar though, you need a blatantly out-of-bounds array access that is unreachable, so you can avoid it if you avoid generating nonsensical code with your code generator. -- Eric Botcazou
