On 04/29/2015 04:30 AM, rohitarul...@freescale.com wrote:
Jeff, I have made the changes as per your comments and attached the patch.
If the patch is OK, I will proceed with the regression tests.
This patch refers back to 60158 and based on what I see in 60158, it
appears I should be looking for a .data.rel.ro.local section which
contains the address of a string constant. But the constants are being
put into .rodata.str1.4. And if the issue is we're putting bits into
the wrong section and don't have an appropriate .fixup section, then
ISTM that the test should be compiled, then objdump used to verify the
sections and/or relocations.
An additional concern is that I get the same code for the included
testcase with or without your changes. This is with a
powerpc-softfloat-linux-gnuspe configured compiler -- which matches what
I saw in pr 60158.
So while the patch seems reasonable, I'm concerned that I've been unable
to show it changing anything.
Thoughts?
Jeff
