On 04/29/2015 01:55 AM, Mikhail Maltsev wrote:
[ Big Snip ]

Couple minor issues.

Can you please check the changes to do_jump_1, the indention looked weird in the patch. If it's correct, just say so.

The ChangeLog needed some work. I'm attaching the one I'd use for the patch as it stands today. There were some functions that had changed, but which weren't referenced and other minor oversights that I've fixed. I suspect you'll need to adjust it slightly as you fix PEEP2_EOB (see below).

One significant question/issue.

The definition of PEEP2_EOB looks wrong. I don't see how you can safely cast pc_rtx to an rtx_insn * since it's an RTX rather than rtx chain object. Maybe you're getting away with it because it's used as marker. But it still feels wrong. You'd probably be better off creating a unique rtx_insn * object and using that as the marker.

Otherwise it's ready to go.

jeff

Attachment: as_insn3.cl
Description: application/simple-filter

Reply via email to