On Fri, Mar 06, 2015 at 10:03:46AM +0000, pins...@gmail.com wrote:
> > On Mar 6, 2015, at 1:45 AM, James Greenhalgh <james.greenha...@arm.com>
> > wrote:
> >
> >> On Thu, Feb 12, 2015 at 03:37:33PM +0000, Christophe Lyon wrote:
> >>> On 8 February 2015 at 03:24, Andrew Pinski <pins...@gmail.com> wrote:
> >>> On Fri, Feb 6, 2015 at 5:02 PM, Andrew Pinski <pins...@gmail.com> wrote:
> >>> PR target/64893
> >>> * config/aarch64/aarch64-builtins.c
> >>> (aarch64_init_simd_builtins):
> >>> Change the first argument type to size_type_node and add
> >>> another
> >>> size_type_node.
> >>> (aarch64_simd_expand_builtin): Handle the new argument to
> >>> AARCH64_SIMD_BUILTIN_LANE_CHECK and don't ICE but rather
> >>> print an out when the first two arguments are not
> >>> nonzero integer constants.
> >>> * config/aarch64/arm_neon.h (__AARCH64_LANE_CHECK):
> >>> Pass the sizeof directly to __builtin_aarch64_im_lane_boundsi.
> >>>
> >>> testsuite/ChangeLog:
> >>>
> >>> * c-c++-common/torture/aarch64-vect-lane-1.c: New testcase.
> >>> * c-c++-common/torture/aarch64-vect-lane-2.c: New testcase.
> >> In case you haven't noticed, aarch64-vect-lane-2.c FAILs when compiled at
> >> -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
> >> but PASSes with the other optimization levels.
> >
> > Hi Andrew,
> >
> > Did you get a chance to look at this? Given the way that your error
> > checking works, the test probably just needs a dg-skip-if -flto
> > directive. Did you intend to come back to this and make it fail earlier
> > than link time with -flto?
> >
> > If I don't hear otherwise, I'll propose the patch adding dg-skip-if on
> > Monday.
>
> Yes that is the correct approach as I see it.
Thanks for the confirmation. In the end I settled on XFAILing (It would be
nice to catch the error early enough that one day this test PASSes) the
test rather than skipping it.
I committed the attached patch as obvious as r221233.
Thanks,
James
---
2015-03-06 James Greenhalgh <james.greenha...@arm.com>
* c-c++-common/torture/aarch64-vect-lane-2.c: XFAIL for LTO
compiles using the linker plugin.
Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog (revision 221232)
+++ gcc/testsuite/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2015-03-06 James Greenhalgh <james.greenha...@arm.com>
+
+ * c-c++-common/torture/aarch64-vect-lane-2.c: XFAIL for LTO
+ compiles using the linker plugin.
+
2015-03-06 Eric Botcazou <ebotca...@adacore.com>
* g++.dg/other/dump-ada-spec-3.C: Remove include and adjust.
Index: gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c
===================================================================
--- gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c (revision 221232)
+++ gcc/testsuite/c-c++-common/torture/aarch64-vect-lane-2.c (working copy)
@@ -1,4 +1,5 @@
// { dg-do compile { target "aarch64*-*-*" } }
+// { dg-xfail-if "" { *-*-* } { "-flto -fuse-linker-plugin" } { "" } }
int
search_line_fast (void)
{
