On Thu, Feb 12, 2015 at 03:37:33PM +0000, Christophe Lyon wrote: > On 8 February 2015 at 03:24, Andrew Pinski <pins...@gmail.com> wrote: > > On Fri, Feb 6, 2015 at 5:02 PM, Andrew Pinski <pins...@gmail.com> wrote: > > PR target/64893 > > * config/aarch64/aarch64-builtins.c > > (aarch64_init_simd_builtins): > > Change the first argument type to size_type_node and add another > > size_type_node. > > (aarch64_simd_expand_builtin): Handle the new argument to > > AARCH64_SIMD_BUILTIN_LANE_CHECK and don't ICE but rather > > print an out when the first two arguments are not > > nonzero integer constants. > > * config/aarch64/arm_neon.h (__AARCH64_LANE_CHECK): > > Pass the sizeof directly to __builtin_aarch64_im_lane_boundsi. > > > > testsuite/ChangeLog: > > > > * c-c++-common/torture/aarch64-vect-lane-1.c: New testcase. > > * c-c++-common/torture/aarch64-vect-lane-2.c: New testcase. > In case you haven't noticed, aarch64-vect-lane-2.c FAILs when compiled at > -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects > but PASSes with the other optimization levels.
Hi Andrew, Did you get a chance to look at this? Given the way that your error checking works, the test probably just needs a dg-skip-if -flto directive. Did you intend to come back to this and make it fail earlier than link time with -flto? If I don't hear otherwise, I'll propose the patch adding dg-skip-if on Monday. Cheers, James
