Bernd Schmidt <ber...@codesourcery.com> writes:
> On 07/06/11 20:06, Richard Sandiford wrote:
>> Bernd Schmidt <ber...@codesourcery.com> writes:
>>> At some point we've grown a shift_truncation_mask hook, but we're not
>>> using it everywhere we're masking shift counts. This patch changes the
>>> instances I found.
>> 
>> The documentation reads:
>> 
>>  Note that, unlike @code{SHIFT_COUNT_TRUNCATED}, this function does
>>  @emph{not} apply to general shift rtxes; it applies only to instructions
>>  that are generated by the named shift patterns.
>
> Ouch. That is one seriously misnamed hook then.

Yeah.  I take the blame for that, sorry :-(

>> I think you need to update the documentation, and check that existing
>> target definitions do in fact apply to shift rtxes as well.
>
> Until I can do that, I've reverted this patch.

Thanks.

Richard

Reply via email to