On Fri, Apr 22, 2011 at 1:26 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Fri, Apr 22, 2011 at 01:19:17PM -0700, Easwaran Raman wrote:
>
> The ChangeLog entry has various issues:
>
>> 2011-04-22 Easwaran Raman <era...@google.com>
>>
>> PR rtl-optimization/44194
>
> This should have tab before PR as well.
>
>> * dse.c (header files): Include tree-flow.h.
>
> This should be just
> * dse.c: Include tree-flow.h.
>
>> (group_info): Add fields.
>
> (struct group_info): Add escaped_n and escaped_p fields.
>
> (it is always better to be be explicit on what you added).
>
>> (globals): Add a new variable kill_on_calls.
>
> (kill_on_calls): New variable.
>
>> (get_group_info): Initialize added fields.
>
> Instead of added fields again mention which fields were added.
>
>> 2011-04-22 Easwaran Raman <era...@google.com>
>>
>> PR rtl-optimization/44194
>
> Again, tab before PR.
>
>> * gcc.dg/pr44194-1.c: New test.
>
> Jakub
>
Thanks for the comments. The fixed ChangeLog given below.
-Easwaran
2011-04-22 Easwaran Raman <era...@google.com>
PR rtl-optimization/44194
* dse.c: Include tree-flow.h.
(group_info): Add escaped_n and escaped_p fields.
(kill_on_calls): New variable.
(get_group_info): Initialize gi->escaped_n and gi->escaped_p.
(dse_step0): Initialize kill_on_calls.
(can_escape): New function.
(record_store): Pass EXPR corresponding to MEM to
set_usage_bits.
(dse_step2_nospill): Set kill_on_calls based on
group->escaped_n and group->escaped_n.
(scan_reads_nospill): Handle call instructions.
(find_insn_before_first_wild_read): Remove the function.
(dse_step3_scan): Remove call to find_insn_before_first_wild_read.
(dse_step5_nospill): Do not kill everything on call.
testsuite/ChangeLog:
2011-04-22 Easwaran Raman <era...@google.com>
PR rtl-optimization/44194
* gcc.dg/pr44194-1.c: New test.
