On Fri, Apr 22, 2011 at 01:19:17PM -0700, Easwaran Raman wrote:

The ChangeLog entry has various issues:

> 2011-04-22  Easwaran Raman  <era...@google.com>
> 
> PR rtl-optimization/44194

This should have tab before PR as well.

>       * dse.c (header files): Include tree-flow.h.

This should be just
        * dse.c: Include tree-flow.h.

>       (group_info): Add fields.

        (struct group_info): Add escaped_n and escaped_p fields.

(it is always better to be be explicit on what you added).

>       (globals): Add a new variable kill_on_calls.

        (kill_on_calls): New variable.

>       (get_group_info): Initialize added fields.

Instead of added fields again mention which fields were added.

> 2011-04-22  Easwaran Raman  <era...@google.com>
> 
> PR rtl-optimization/44194

Again, tab before PR.

>       * gcc.dg/pr44194-1.c: New test.

        Jakub

Reply via email to