------- Comment #3 from hjl at lucon dot org 2007-09-12 13:54 ------- (In reply to comment #2) > Subject: Re: [4.3 Regression] Revision 128239 causes libgomp failure > > Hi, > I´ve just tested ia64-linux and x86_64-linux on our testers and both are > clean WRT libgomp: > === libgomp Summary === > > # of expected passes 496 > it might be some sort of race condition (I sometimes see libgomp > failures appear and go such as:
Have you compared the times to take for "make check" on libgomp between revision 128238 and HEAD? With C libgomp tests only, revision 128238 takes less than 15 seconds on a 1.5GHz ia64 machine. Revision 128239 takes more than 20 minutes plus random failures. > > libgomp.fortran/omp_parse3.f90 -O0 execution test > > One obvious difference is that we now consider functions produced by OMP > lowering inlinable. This can be avoided by: > > Index: omp-low.c > =================================================================== > *** omp-low.c (revision 128412) > --- omp-low.c (working copy) > *************** expand_omp_parallel (struct omp_region * > *** 2589,2594 **** > --- 2589,2595 ---- > /* Inform the callgraph about the new function. */ > DECL_STRUCT_FUNCTION (child_fn)->curr_properties > = cfun->curr_properties; > + DECL_UNINLINABLE (child_fn) = true; > cgraph_add_new_function (child_fn, true); > > /* Fix the callgraph edges for child_cfun. Those for cfun will be > It makes no differences to me. -- hjl at lucon dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at redhat dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33389