Viktor Griph <[EMAIL PROTECTED]> writes:
> On Sat, 1 Mar 2008, Dan Espen wrote:
> > I just looked at the code for a few minutes and this
> > doesn't seem right:
> >
> > add_window.c:
> >
> > setup_icon_background_parameters(...
> >
> >     if (SHAS_ICON_BACKGROUND_RELIEF(&pstyle->flags))
> >     {
> >             fw->icon_background_relief =
> >                     SGET_ICON_BACKGROUND_RELIEF(*pstyle);
> >     }
> >     else
> >     {
> >             fw->icon_background_relief = ICON_RELIEF_WIDTH;
> >     }
> >
> >
> > Changing ICON_RELIEF_WIDTH to zero makes the issue go away.
> >
> > Why is it setting the relief width to the default of
> > 2 pixels when the icon isn't supposed to have a relief?
> 
> The man page specifies that the default relief is 2. But that it only 
> applies to icons with a background picture. I'm not sure what that mean 
> and don't have time to look at the logic in the code to see what it does.

Well, I'll go ahead and fix it after thinking about it a while.
There is a default, if you say:

Style * IconBackgroundRelief

with no number, it uses 2.
But I think the default is to use no relief.

The logic that paints the relief doesn't pay much
attention to the flag indicating there is a relief
it uses the width being non-zero as it's cue.

-- 
Dan Espen                           E-mail: [EMAIL PROTECTED]

Reply via email to