On Fri, 29 Feb 2008, Viktor Griph wrote:

On Fri, 29 Feb 2008, Duane Paddock wrote:

 fvwm 2.5.25 core dumps on Solaris 9 SPARC when I open an xterm from the
 built-in menu.

The problem is with the ARGB detection in case no visual format is found.
I've comitted a fix.

/Viktor


Thanks Viktor.

The changes work great!

I still receive this "error" in my .xsession file, but it doesn't seem to affect anything.

[fvwm][parse_colorset]: <<ERROR>> error reading root background.

Looking at the code, I'm not sure it should be flagged as an error.

Thoughts?

I've removed the else block in fvwm/colorset.c with no ill effect.

--- fvwm/colorset.c.orig        2008-02-04 15:20:41.000000000 -0500
+++ fvwm/colorset.c     2008-02-29 12:43:35.037205000 -0500
@@ -1185,12 +1185,7 @@
                                        }
                                }
                        }
-                       else
-                       {
-                               fvwm_msg(
-                                       ERR, "parse_colorset",
-                                       "error reading root background");
-                       }
+
                        if (image != None)
                        {
                                XDestroyImage(image);

Duane.

Reply via email to