On 9/21/2012 11:17 PM, Jim Harris wrote:
>> What about a change similar to what Alexander Motin did in
>>
>> http://lists.freebsd.org/pipermail/svn-src-head/2012-June/038196.html
>
> Ah, yes. I was thinking you had CAM_DEBUG enabled which is why you
> were seeing this spew - but that's not the case. This indeed should
> be fixed and not just ignored.
>
> Seeing the attributions on Alexander's commit, you certainly seem to
> have a monopoly on controllers that exhibit this problem on FreeBSD.
> :)
>
> I believe the CAM_LUN_INVALID here should be fixed as well, similar to
> the twa commit. If you send me a revised patch I will commit it.
Thanks, yes seems to be déjà vu all over again with this manufacturer :)
I think this is correct ?
0(ich10)# diff -u tws_cam.c.orig tws_cam.c
--- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400
+++ tws_cam.c 2012-09-22 08:21:36.000000000 -0400
@@ -529,10 +529,10 @@
if ( ccb->ccb_h.target_lun ) {
TWS_TRACE_DEBUG(sc, "invalid lun error",0,0);
- ccb->ccb_h.status |= CAM_LUN_INVALID;
+ ccb->ccb_h.status |= CAM_SEL_TIMEOUT;
} else {
TWS_TRACE_DEBUG(sc, "invalid target error",0,0);
- ccb->ccb_h.status |= CAM_TID_INVALID;
+ ccb->ccb_h.status |= CAM_SEL_TIMEOUT;
}
} else {
1(ich10)#
---Mike
>
> Thanks,
>
> -Jim
>
>
>>
>> 0(ich10)# diff -u tws_cam.c.orig tws_cam.c
>> --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400
>> +++ tws_cam.c 2012-09-21 20:11:11.000000000 -0400
>> @@ -532,7 +532,7 @@
>> ccb->ccb_h.status |= CAM_LUN_INVALID;
>> } else {
>> TWS_TRACE_DEBUG(sc, "invalid target error",0,0);
>> - ccb->ccb_h.status |= CAM_TID_INVALID;
>> + ccb->ccb_h.status |= CAM_SEL_TIMEOUT;
>> }
>>
>> } else {
>> 1(ich10)#
>>
>> ---Mike
>>
>>
>> --
>> -------------------
>> Mike Tancsa, tel +1 519 651 3400
>> Sentex Communications, m...@sentex.net
>> Providing Internet services since 1994 www.sentex.net
>> Cambridge, Ontario Canada http://www.tancsa.com/
>
>
--
-------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, m...@sentex.net
Providing Internet services since 1994 www.sentex.net
Cambridge, Ontario Canada http://www.tancsa.com/
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
