https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219687
--- Comment #31 from Po-Chuan Hsieh <sunp...@freebsd.org> ---
(In reply to Helen Koike from comment #28)
1. Either remove PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX} or change this port as
net/py-google-compute-engine.
We add py- to the directory name and pyXX- to package name for Python
libraries/modules.
Please consider if this port is more of a library or an application.
2. We have ntpdate in base system (/usr/sbin/ntpdate). Is there any reason to
use the one from ports?
3. There is compilation error with Python 3. Please add a patch for it.
byte-compiling
/usr/ports/works/usr/ports/net/google-compute-engine/work/stage/usr/local/lib/python3.6/site-packages/google_compute_engine/network_utils.py
to network_utils.cpython-36.pyc
File
"/usr/local/lib/python3.6/site-packages/google_compute_engine/network_utils.py",
line 47
except Exception, e:
^
SyntaxError: invalid syntax
4. Please sort RUN_DEPENDS and USE_PYTHON.
5. Use REINPLACE_ARGS=-i '' to avoid saving backup files.
"@${REINPLACE_CMD} -i -e" in post-patch: will save backup files with "-e"
suffix.
% ls -l google_compute_engine/network_setup/network_setup.py*
-rwxr-xr-x 1 sunpoet wheel 6454 Jul 29 20:52
google_compute_engine/network_setup/network_setup.py
-rwxr-xr-x 1 sunpoet wheel 6454 Jul 19 00:49
google_compute_engine/network_setup/network_setup.py-e
It should be "REINPLACE_ARGS=-i ''" to avoid saving backup files.
% grep REINPLACE_ARGS /usr/ports/Mk/bsd.port.mk
REINPLACE_ARGS?= -i.bak
REINPLACE_CMD?= ${SED} ${REINPLACE_ARGS}
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
