https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211641
Kubilay Kocak <ko...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |merge-quarterly?
Keywords| |needs-patch, needs-qa,
| |patch
--- Comment #10 from Kubilay Kocak <ko...@freebsd.org> ---
(In reply to vladimir.chukharev from comment #9)
If you'd like this to be a workaround in leui of fixing the root cause that's
fine.
A couple of review comments on attachment 173546
* Use PYTHONPREFIX_SITELIBDIR for
${STAGEDIR}${PREFIX}/lib/python2.7/site-packages/tvtk/array_ext.so
* The post-install -> post-stage switch is unexplained (for stripping).
post-install should be fine for both commands executed
* The additional of mayavi2 executable is unexplained. Related, for version
suffixed script names, USE_PYTHON=concurrent is preferred.
* os.environ["LD_LIBRARY_PATH"] = "/usr/local/lib/gcc48" should likely use
%%LOCALBASE%% in files, and be replaced (REINPLACE_CMD) in post-patch to to be
prefix safe. You'll probably need SUB_FILES too.
Finally please reconfirm QA across as many arch/versions as possible, as this
will be committed then merged to the quarterly branch.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
