On 2013/02/16 15:46, Mikhail T. wrote: > 15.02.2013 23:21, Ian Lepore ???????(??): >> Since /home/ian/foo/BSDmakefile is not building something that is part >> of the freebsd world, or the freebsd kernel, then according to that >> paragraph, a build using that makefile should not be affected >> by /etc/src.conf. > Maybe it should not be affected. But it is. And the only way to avoid it > is by using an undocumented knob. If the documentation properly > documents the feature, then the implementation of it is faulty. > > As suggested earlier, perhaps, the file should only be included, if > something special is put into environment (by /usr/src/Makefile). > Instead it bsd.own.mk currently sucks-in /etc/src.conf by default -- and > one has to set an undocumented flag to avoid that. Something like this > (untested): > > Index: Makefile > =================================================================== > --- Makefile (revision 246385) > +++ Makefile (working copy) > @@ -293,7 +293,7 @@ > # the system bsdmake-like utility to be overridden. > # > MMAKEENV= MAKEOBJDIRPREFIX=${MAKEPATH} \ > - DESTDIR= \ > + DESTDIR= _WITH_SRCCONF= \ > INSTALL="sh ${.CURDIR}/tools/install.sh" > MMAKE= ${MMAKEENV} ${MAKE} \ > -D_UPGRADING \ > Index: share/mk/bsd.own.mk > =================================================================== > --- share/mk/bsd.own.mk (revision 246385) > +++ share/mk/bsd.own.mk (working copy) > @@ -115,7 +115,7 @@ > .if !target(__<bsd.own.mk>__) > __<bsd.own.mk>__: > > -.if !defined(_WITHOUT_SRCCONF) > +.if defined(_WITH_SRCCONF) > SRCCONF?= /etc/src.conf > .if exists(${SRCCONF}) > .include "${SRCCONF}" > > Yours, > > -mi > > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org" > > /etc/src.conf is never included.
MMAKE* seems for usr.bin/make. <bsd.own.mk> has 2 !defined(_WITHOUT_SRCCONF). first is changed, but second is not. Why? _WITH_SRCCONF is defined only root Makefile. Is this correct? I think subdir's Makefile need to include /etc/src.conf. _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"