On 07/13/2011 12:26 PM, Jung-uk Kim wrote:
On Wednesday 13 July 2011 01:23 pm, Jung-uk Kim wrote:
On Wednesday 13 July 2011 01:04 pm, Stephen Montgomery-Smith wrote:
On 07/13/2011 11:59 AM, Stephen Montgomery-Smith wrote:
But code like this seems simpler than my original suggestion:
if (echo "$$4" | grep -E [^[:alnum:]_-]> /dev/null); then echo
\ ${ECHO_MSG} "blah blah."; \
exit 1; \
fi; \
pathname="${DESKTOPDIR}/$$4";
Oh, and use ${GREP} and ${ECHO_CMD} instead of echo and grep.
And maybe the "-E" is unnecessary.
If we actually do "exit 1;", I'd prefer something like that, too.
Actually, this must be moved to 'check-desktop-entries' target, I
believe.
Yes, that seems to be the right place. And the code there is so full of
"exit 1"'s that one more won't be noticed.
_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
