On 22 January 2011 12:53, Chris Rees <utis...@gmail.com> wrote: > On 21 January 2011 21:46, Jan Henrik Sylvester <m...@janh.de> wrote: >> Finally, I found an application worse having that is not in ports and looked >> simple enough to try: Xournal is my first attempt to create a new port. >> >> I followed the handbook and did the basic testing with porttools: There are >> warnings about considering to use DATADIR if the port was DATADIR-safe, but >> I do not assume it to be. >> >> Moreover, there is a warning about my post-patch line. I think the warning >> is wrong, but I am unsure about that line anyhow. The desktop-install target >> in Makefile.in is wrong for FreeBSD, but there is probably a better way to >> fix it. >> >> Is my attempt to use the desktop-install target via post-install correct? >> >> Do all the files installed by the post-install target go to the correct >> locations? >> >> Is there anything else I should fix before submitting the port as pr? >> >> In case the attachment does not make it to the list, I have placed a copy >> here: http://www.math.uni-hamburg.de/home/sylvester/xournal.shar >> > > The DATADIR whines are addressed in this patch, have a look: > > http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff > > That's all I had time to look at at the moment, perhaps others can help! >
Alright, came back and now the patch has the desktop-install target defined instead of using the post-install. This is reflected in the patch linked above ^^^ I've stuck it in my Tinderbox for testing, follow it here: http://tinderbox.bayofrum.net/index.php?action=describe_port&id=196 Chris _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
