Ok for the function.
Please find the review here: https://reviews.freebsd.org/D2141

Regards,

Emeric

----- Mail original -----
De: "Hans Petter Selasky" <h...@selasky.org>
À: "Emeric POUPON" <emeric.pou...@stormshield.eu>, "Adrian Chadd" 
<adr...@freebsd.org>
Cc: "freebsd-net" <freebsd-net@freebsd.org>
Envoyé: Mercredi 25 Mars 2015 14:41:46
Objet: Re: Fragment questions

On 03/24/15 10:26, Emeric POUPON wrote:
> Hello,
>
> Please find attached a proposal using atomic_fetchadd.
>
> Best Regards,
>
> Emeric

Hi,

Your proposal using atomic_fetchadd() looks fine to me.

I think however we should define the code like a function, because the 
htons() might be a macro, referring the input argument multiple times ...

What do you think?

--HPS

_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to