Hello, Yes indeed, it has already been fixed! However, the second point seems to be still here...
Regards, Emeric ----- Mail original ----- De: "Hans Petter Selasky" <h...@selasky.org> À: "Emeric POUPON" <emeric.pou...@stormshield.eu>, "freebsd-net" <freebsd-net@freebsd.org> Envoyé: Jeudi 19 Mars 2015 13:54:33 Objet: Re: Fragment questions On 03/19/15 12:38, Emeric POUPON wrote: > Hello, > > I noticed two questionable things in the fragmentation code: > - in ip_fragment, we do not copy the flowid from the original mbuf to the > fragmented mbuf. Therefore we may output very desynchronized fragments (first > fragment emitted far later the second fragment, etc.) > - in the ip_newid macro, we do "htons(V_ip_id++))" if we do not use > randomized id. In multi core systems, we may emit successive packets with the > same id. > > Both problems combined lead to bad packet reassembly on the remote host. > > What do you think? > Hi, I think this issue is already fixed: https://svnweb.freebsd.org/base/head/sys/netinet/ip_output.c?revision=278103&view=markup --HPS _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
