The following reply was made to PR kern/149185; it has been noted by GNATS.
From: Bernhard Schmidt <bschm...@techwires.net>
To: Alex Kozlov <s...@rm-rf.kiev.ua>
Cc: bug-follo...@freebsd.org, Juergen Lock <n...@jelal.kn-bremen.de>,
rpa...@freebsd.org
Subject: Re: kern/149185: [rum] [panic] panic in rum(4) driver on 8.1-R
Date: Thu, 5 Aug 2010 18:25:32 +0200
--00c09f89939bd0b2e9048d15ff5b
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Thu, Aug 5, 2010 at 11:11, Alex Kozlov <s...@rm-rf.kiev.ua> wrote:
> On Thu, Aug 05, 2010 at 10:05:39AM +0200, Bernhard Schmidt wrote:
>> On Thu, Aug 5, 2010 at 08:52, Alex Kozlov <s...@rm-rf.kiev.ua> wrote:
>> > On Wed, Aug 04, 2010 at 10:02:35PM +0200, Juergen Lock wrote:
>> >> =A0Regarding the 8.1 if_rum(4) panics... =A0I got a similar one, extr=
acted
>> >> a dump and tried to gather some info for someone who knows the code:
>> >>
>> >> =A0The zero divide fault was because (apparently) rate was unitialize=
d,
>> >> as is
>> >>
>> >> =A0 =A0 =A0 ((struct ieee80211_node *) m->M_dat.MH.MH_pkthdr.rcvif)->=
ni_vap->iv_txparms[0]
>> >>
>> >> i.e. struct ieee80211_txparam &vap->iv_txparms[0] in case it matters.
>> > Yes, its seems that ratectl framework sometimes set ni->ni_txrate to 0
>> > This can be mitigated by patch [1] or by setting ucastrate option in
>> > ifconfig. Still real issue need to be solved.
>>
>> The real issue is that prior to an association (RUN state)
>> ieee80211_ratectl_node_init() is not called, therefore iv_bss is not
>> configured in any way.
> ieee80211_ratectl_node_init() called from iv_newstate when switching to
> IEEE80211_S_RUN state. Most drivers do the same. Is it wrong?
> Some call it from iv_newassoc, but this marked /* XXX move */
>
>> I'll look into that if no one beats me.
> Thanks.
Please give attached patch a try, it should fix the issue for rum and
all other drivers relying on the new ratectl stuff.
Thanks
--=20
Bernhard
--00c09f89939bd0b2e9048d15ff5b
Content-Type: application/octet-stream;
name="net80211_ratectl_node_init.diff"
Content-Disposition: attachment; filename="net80211_ratectl_node_init.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gchtkki90
SW5kZXg6IHN5cy9uZXQ4MDIxMS9pZWVlODAyMTFfbm9kZS5jCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9u
ZXQ4MDIxMS9pZWVlODAyMTFfbm9kZS5jCShyZXZpc2lvbiAyMTA4NjIpCisrKyBzeXMvbmV0ODAy
MTEvaWVlZTgwMjExX25vZGUuYwkod29ya2luZyBjb3B5KQpAQCAtODE3LDYgKzgxNyw3IEBAIGll
ZWU4MDIxMV9zdGFfam9pbihzdHJ1Y3QgaWVlZTgwMjExdmFwICp2YXAsIHN0cnVjCiAJaWYgKGll
ZWU4MDIxMV9pc2VycF9yYXRlc2V0KCZuaS0+bmlfcmF0ZXMpKQogCQluaS0+bmlfZmxhZ3MgfD0g
SUVFRTgwMjExX05PREVfRVJQOwogCWllZWU4MDIxMV9ub2RlX3NldHVwdHhwYXJtcyhuaSk7CisJ
aWVlZTgwMjExX3JhdGVjdGxfbm9kZV9pbml0KG5pKTsKIAogCXJldHVybiBpZWVlODAyMTFfc3Rh
X2pvaW4xKGllZWU4MDIxMV9yZWZfbm9kZShuaSkpOwogfQpAQCAtMTQwMSw2ICsxNDAyLDcgQEAg
aWVlZTgwMjExX2Zha2V1cF9hZGhvY19ub2RlKHN0cnVjdCBpZWVlODAyMTF2YXAgKnYKICNlbmRp
ZgogCQl9CiAJCWllZWU4MDIxMV9ub2RlX3NldHVwdHhwYXJtcyhuaSk7CisJCWllZWU4MDIxMV9y
YXRlY3RsX25vZGVfaW5pdChuaSk7CiAJCWlmIChpYy0+aWNfbmV3YXNzb2MgIT0gTlVMTCkKIAkJ
CWljLT5pY19uZXdhc3NvYyhuaSwgMSk7CiAJCS8qIFhYWCBub3QgcmlnaHQgZm9yIDgwMi4xeC9X
UEEgKi8KQEAgLTE0NzAsNiArMTQ3Miw3IEBAIGllZWU4MDIxMV9hZGRfbmVpZ2hib3Ioc3RydWN0
IGllZWU4MDIxMXZhcCAqdmFwLAogCQlpZiAoaWVlZTgwMjExX2lzZXJwX3JhdGVzZXQoJm5pLT5u
aV9yYXRlcykpCiAJCQluaS0+bmlfZmxhZ3MgfD0gSUVFRTgwMjExX05PREVfRVJQOwogCQlpZWVl
ODAyMTFfbm9kZV9zZXR1cHR4cGFybXMobmkpOworCQlpZWVlODAyMTFfcmF0ZWN0bF9ub2RlX2lu
aXQobmkpOwogCQlpZiAoaWMtPmljX25ld2Fzc29jICE9IE5VTEwpCiAJCQlpYy0+aWNfbmV3YXNz
b2MobmksIDEpOwogCQkvKiBYWFggbm90IHJpZ2h0IGZvciA4MDIuMXgvV1BBICovCkBAIC0yMzM4
LDYgKzIzNDEsNyBAQCBpZWVlODAyMTFfbm9kZV9qb2luKHN0cnVjdCBpZWVlODAyMTFfbm9kZSAq
bmksIGludAogCSk7CiAKIAlpZWVlODAyMTFfbm9kZV9zZXR1cHR4cGFybXMobmkpOworCWllZWU4
MDIxMV9yYXRlY3RsX25vZGVfaW5pdChuaSk7CiAJLyogZ2l2ZSBkcml2ZXIgYSBjaGFuY2UgdG8g
c2V0dXAgc3RhdGUgbGlrZSBuaV90eHJhdGUgKi8KIAlpZiAoaWMtPmljX25ld2Fzc29jICE9IE5V
TEwpCiAJCWljLT5pY19uZXdhc3NvYyhuaSwgbmV3YXNzb2MpOwpJbmRleDogc3lzL25ldDgwMjEx
L2llZWU4MDIxMV9zdGEuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvbmV0ODAyMTEvaWVlZTgwMjExX3N0
YS5jCShyZXZpc2lvbiAyMTA4NjIpCisrKyBzeXMvbmV0ODAyMTEvaWVlZTgwMjExX3N0YS5jCSh3
b3JraW5nIGNvcHkpCkBAIC02MCw2ICs2MCw3IEBAIF9fRkJTRElEKCIkRnJlZUJTRCQiKTsKICNp
ZmRlZiBJRUVFODAyMTFfU1VQUE9SVF9TVVBFUkcKICNpbmNsdWRlIDxuZXQ4MDIxMS9pZWVlODAy
MTFfc3VwZXJnLmg+CiAjZW5kaWYKKyNpbmNsdWRlIDxuZXQ4MDIxMS9pZWVlODAyMTFfcmF0ZWN0
bC5oPgogCiAjZGVmaW5lCUlFRUU4MDIxMV9SQVRFMk1CUyhyKQkoKChyKSAmIElFRUU4MDIxMV9S
QVRFX1ZBTCkgLyAyKQogCkBAIC0xNTk2LDYgKzE1OTcsNyBAQCBzdGFfcmVjdl9tZ210KHN0cnVj
dCBpZWVlODAyMTFfbm9kZSAqbmksIHN0cnVjdCBtYgogCQkJICAgICBJRUVFODAyMTFfRl9KT0lO
IHwgSUVFRTgwMjExX0ZfRE9CUlMpOwogCQkJaWVlZTgwMjExX3NldHVwX2Jhc2ljX2h0cmF0ZXMo
bmksIGh0aW5mbyk7CiAJCQlpZWVlODAyMTFfbm9kZV9zZXR1cHR4cGFybXMobmkpOworCQkJaWVl
ZTgwMjExX3JhdGVjdGxfbm9kZV9pbml0KG5pKTsKIAkJfSBlbHNlIHsKICNpZmRlZiBJRUVFODAy
MTFfU1VQUE9SVF9TVVBFUkcKIAkJCWlmIChJRUVFODAyMTFfQVRIX0NBUCh2YXAsIG5pLCBJRUVF
ODAyMTFfTk9ERV9BVEgpKQo=
--00c09f89939bd0b2e9048d15ff5b--
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
