> Xin, good day.
>
> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote:
> > The attached patch should fix this, any objections?
>
> Yes, you missed negation operator in the copyin check. The issue
> was already fixed by hrs@ two hours ago:
> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796
sorry to barge in, but:
if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
is not clear,
if ((options & ~GIF_FULLOPTS) == 0)
seems to be less offuscated or I'm missing something?
danny
> --
> Eygene
> _ ___ _.--. #
> \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
> / ' ` , __.--' # to read the on-line manual
> )/' _/ \ `-_, / # while single-stepping the kernel.
> `-'" `"\_ ,_.-;_.-\_ ', fsc/as #
> _.-'_./ {_.' ; / # -- FreeBSD Developers handbook
> {_.-``-' {_/ #
> _______________________________________________
> freebsd-curr...@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
>
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
