On Tue, 9 Jun 2009, Xin LI wrote:
Danny Braniss wrote:
Xin, good day.
Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote:
The attached patch should fix this, any objections?
Yes, you missed negation operator in the copyin check. The issue
was already fixed by hrs@ two hours ago:
http://svn.freebsd.org/viewvc/base?view=revision&revision=193796
sorry to barge in, but:
if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
is not clear,
if ((options & ~GIF_FULLOPTS) == 0)
seems to be less offuscated or I'm missing something?
Yes this looks like the usually used idiom (perhaps more efficient
anyway)... I just kept the style consistent with the old code.
Hiroki-san, could you have a look at this and consider if we should use
this idiom?
Also see the mail I had sent in reply to the commit message yesterday.
/bz
--
Bjoern A. Zeeb The greatest risk is not taking one.
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
