On 18-Aug-2004 Julian Elischer wrote:
John Polstra wrote:
There is one problem with netgraph on 64-bit platforms. The ng_msghdr struct is 52 bytes / 4-byte aligned (see ng_message.h). That means the message payload is not well-aligned for 64-bit platforms. It would be nice to fix that (and bump NG_VERSION, of course). Nobody ever guaranteed that the message payload would be aligned, but it makes things a lot more convenient.
if we do this we should do it now so that we have a consistent ABI from 5.3 on..
scott (et al), should we pad an extra 4 bytes in this now? it's low/no risk, but better now than after 5.3 has been released..
I'd really like to see this change happen. Julian, would it require bumping just NG_VERSION, or should NG_ABI_VERSION change too?
John
you'd have to change both.. but we alredy have an NG_ABI version change for 5.3
we COULD even hack ng_socket to convert new and old version messages if we thought we had people that needed it..
the current structure is:
/* A netgraph message */
struct ng_mesg {
struct ng_msghdr {
u_char version; /* == NGM_VERSION */
u_char spare; /* pad to 2 bytes */
u_int16_t arglen; /* length of data */
u_int32_t flags; /* message status */
u_int32_t token; /* match with reply */
u_int32_t typecookie; /* node's type cookie */
u_int32_t cmd; /* command identifier */
u_char cmdstr[NG_CMDSTRSIZ]; /* cmd string + \0 */
} header;
char data[]; /* placeholder for actual data */
};let me see.. 1+1+2+4+4+4+4+32.. hmmmm.. yeah ok,, we could change it to:
/* A netgraph message */
struct ng_mesg {
struct ng_msghdr {
u_char version; /* == NGM_VERSION */
u_char spare; /* pad to 2 bytes */
u_int16_t arglen; /* length of data */
u_int32_t flags; /* message status */
-----------> u_int32_t spare2; /* pad to 8 bytes */
u_int32_t token; /* match with reply */
u_int32_t typecookie; /* node's type cookie */
u_int32_t cmd; /* command identifier */ u_char cmdstr[NG_CMDSTRSIZ]; /* cmd string + \0 */
} header;
char data[]; /* placeholder for actual data */
};
I'd put it there in case the flags ever need to expand..
actually maybe bringing 'token' ot 'typecookie' forward so that the flags would be 64 bit aligned too might be worth it...
_______________________________________________ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[EMAIL PROTECTED]"
