On Fri, May 31, 2002 at 01:25:09PM -0700, Archie Cobbs wrote:
> As a temporary saftey measure, I'll add M_WRITABLE(m) into the
> M_TRAILINGSPACE() macro. However, I see this as a temporary hack;
> the correct fix is to put the burden of writability on the caller.
> After all, M_TRAILINGSPACE() doesn't modify the mbuf data!
I think adding the M_WRITABLE check to M_TRAILINGSPACE is probably
the right thing to do, unless the cost of the extra M_WRITABLE
checks is likely to be significant. I believe the only reason we
didn't add it when we did the M_WRITABLE code originally was to
preserve the previous behaviour of M_TRAILINGSPACE.
I think it was Ian that pointed out that there is no reason to call
M_{LEAD,TRAIL}INGSPACE unless you are going to write into the mbuf's
storage. This means the question of where to check writability is
just a trade off between efficiency and ease of use.
David.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-net" in the body of the message
