-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu, 22 Apr 2010 15:21+0300, Eitan Adler wrote:
> > Just asking opinions, if people want this, I'll make a patch and
> > file a PR.
>
> Is this script correct?
>
> #!/bin/sh
> #
> # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1
> 2009/10/25 01:10:29 kensmith Exp $
> #
>
> # If there is a global system configuration file, suck it in.
> #
> if [ -r /etc/defaults/periodic.conf ]
> then
> . /etc/defaults/periodic.conf
> source_periodic_confs
> fi
>
> bak=/var/backups
> db_loc="/var/db/pkg";
> bk_loc="/$bak/pkgdb.bak.tar"
It's really no big deal, but from a pragmatic view I'd write:
bk_loc="$bak/pkgdb.bak.tar"
Otherwise $bk_loc will contain:
//var/backups/pkgdb.bak.tar
>
> case "$daily_backup_pkgdb_enable" in
> [Yy][Ee][Ss])
> if [ ! -d $db_loc ]
> then
> echo '$daily_backup_pkgdb_enable is enabled but' \
> "$db_loc doesn't exist"
> rc=2
> else
> rc=0
>
> echo ""
> echo "Backing up mail aliases:"
It's really the package directory, no?
> if [ ! -f $bk_loc ]
> then
> echo "no $bk_loc"
> tar -cjf $bk_loc $db_loc || rc=3
How do you plan to capture changes made to /var/db/pkg? If we're
supposed to manually delete /var/backups/pkgdb.bak.tar from time to
time, then the presented code is probably ok.
> fi
> fi;;
>
> *) rc=0;;
> esac
>
> exit $rc
Just my $0.02,
Trond.
- --
- ----------------------------------------------------------------------
Trond Endrestøl | trond.endres...@fagskolen.gjovik.no
ACM, NAS, NUUG, SAGE, USENIX | FreeBSD 8.0-STABLE & Alpine 2.00
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAkvQWvIACgkQbYWZalUoEluyegCfYq/FMpdT9/wRGQyGF8+2WgKQ
aGIAn2S2br054BRHc38IpB4uWYVYH94I
=GA9V
-----END PGP SIGNATURE-----
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
