this patch looks good, however, one nit:
In message: <[EMAIL PROTECTED]>
Oliver Fromme <[EMAIL PROTECTED]> writes:
: + if (stat("/dev", &stst) != 0)
: + warning("Can't stat /dev: %m");
: + else {
: + if (stst.st_dev == root_devno)
: + devfs++;
: + }
is more succinctly expressed as:
+ if (stat("/dev", &stst) != 0)
+ warning("Can't stat /dev: %m");
+ else if (stst.st_dev == root_devno)
+ devfs++;
Also, kenv(KENV_GET, ... is used a lot. Maybe it makes sense to have
a simple kenvget call. Would make a few lines a little shorter if
nothing else.
Otherwise, I think this is a great patch. I don't see other problems
with it.
Warner
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
