On Tue, 2006-Apr-18 14:02:07 -0400, Coleman Kane wrote:
A few comments on the shellscript:
>+ rcargsize=`echo $rc_arg`
>+ rcargsize=${#rcargsize}
Try rcargsize=$((${#rc_arg} + 1))
>- return 1
>+ (echo_fancy "FAILED" `expr 10 + $rcargsize
>- 1`) && return 1
Try echo_fancy "FAILED" $((10 + $rcargsize -
1)) && return 1
>+echo_fancy () {
...
>+ namesize=`echo -n $name`
>+ namesize=${#namesize}
or namesize=${#name}
>+ padding=""
>+ paddingsize=$(($columns - 15 - $2 - $namesize))
>+ until [ 0 = ${paddingsize} ]; do
>+ padding=" $padding"
>+ paddingsize=$(($paddingsize - 1))
>+ done
This particular block of code appears unnecessary (since $padding is unused).
>+ paddingsize=$((60 - $namesize - $rc_argsize))
>+ until [ 0 = ${paddingsize} ]; do
>+ padding=" $padding"
>+ paddingsize=$(($paddingsize - 1))
>+ done
For safety, the conditions should probably be [ 0 -ge ${paddingsize} ]
I don't see any alternative to the until loop. If efficiency turns out
to be a real issue then you could try doing the expansion in multiple
goes. Eg:
until [ 8 -gt ${paddingsize} ]; do
padding=" $padding"
paddingsize=$(($paddingsize - 8))
done
until [ 0 -ge ${paddingsize} ]; do
padding=" $padding"
paddingsize=$(($paddingsize - 1))
done
--
Peter Jeremy
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
