On Sat, 2 Oct 2004, David Schultz wrote:

Date: Sat, 2 Oct 2004 16:12:11 -0400
From: David Schultz <[EMAIL PROTECTED]>
To: Michael Reifenberger <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Subject: Re: Protection from the dreaded "rm -fr /"

On Sat, Oct 02, 2004, Michael Reifenberger wrote:
On Sat, 2 Oct 2004, David Schultz wrote:
...
Do you also want to be able to swap to the root partition while
it's mounted?  We can bring back that feature, too.  But
personally, I don't see anything wrong with the view that
operations that are guaranteed to shoot people in the foot should
be disallowed.


Every anti foot shooting takes time to check for. A strncmp for every arg is maybe ok. Traversing the tree for realpath is not. The job for `rm` is to remove whatever it is given to get removed. As fast as possible. Nothing else.

Sigh. The original patch that just used strcmp() wouldn't have increased the time to execute rm by more than a few hundred nanoseconds.


Wasn't there a discussion recently to increase ARG_MAX...? :-)


Bye/2 --- Michael Reifenberger, Business Development Manager SAP-Basis, Plaut Consulting Comp: [EMAIL PROTECTED] | Priv: [EMAIL PROTECTED] http://www.plaut.de | http://www.Reifenberger.com

_______________________________________________
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to