Andriy Gapon <a...@freebsd.org> wrote: > on 09/07/2012 22:49 Sean Bruno said the following: > > Ran into some symbol errors with the dtraceall module when using the > > *old* nfs client. > > > > I think that this is more or less the right thing to do, but I'm not > > sure. > > > > --- //depot/yahoo/ybsd_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > 2011-11-02 23:46:55.000000000 0000 > > +++ /home/seanbru/dtrace_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > 2011-11-02 23:46:55.000000000 0000 > > @@ -66,8 +66,11 @@ > > MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1); > > MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1); > > MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1); > > +#if defined (NFSCL) > > MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1); > > +#else /* defined (NFSCLIENT) */
Any objections to changing this to #elif defined (NFSCLIENT) ? > > MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1); > > +#endif > > #if defined(__amd64__) || defined(__i386__) > > MODULE_DEPEND(dtraceall, fbt, 1, 1, 1); > > MODULE_DEPEND(dtraceall, fasttrap, 1, 1, 1); > > Just to add some noise to the signal - my personal opinion is that nfs support > doesn't have to be in dtraceall. Maybe in something "all-er" :-) I have no opinion on whether or not dtraceall should depend on nfs modules if they are available, but I would prefer it if the dependency was optional. I do not use any nfs modules and the hard-coded dependency made dtraceall useless for me in the past. Unlike Sean I worked around it with a shell function and was too lazy to investigate the cause, though. Fabian
signature.asc
Description: PGP signature
