On Sat, Jan 28, 2012 at 02:39:17PM +0100, Attilio Rao wrote: > 2012/1/28 Attilio Rao <atti...@freebsd.org>: > > 2012/1/28 Ryan Stone <ryst...@gmail.com>: > >> On Fri, Jan 27, 2012 at 10:41 PM, Attilio Rao <atti...@freebsd.org> wrote: > >>> I think what you found out is very sensitive. > >>> However, the patch is not correct as you cannot call > >>> cpuset_setthread() with thread_lock held. > >> > >> Whoops! I actually discovered that for myself and had already fixed > >> it, but apparently I included an old version of the patch in the > >> email. > >> > >>> Hence this is my fix: > >>> http://www.freebsd.org/~attilio/cpuset_root.patch > >> > >> Oh, I do like this better. I tried something similar myself but > >> abandoned it because I misread how sched_affinity() was implemented by > >> 4BSD(I had gotten the impression that once TSF_AFFINITY is set it > >> could never be cleared). > > > > Do you have a pathological test-case for it? Are you going to test the > > patch? > > BTW, I've just now updated the patch in order to remove an added white > line and s/priority/affinity in comments. >
I've tested this patch with what I got of threaded test scenarios, for 14 hours without finding any issues. - Peter _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
