Just a few comments...

> 2) The casting of VFS ops to eopnotsupp() has been removed and
>      vfs_nop*() functions have been put into kern/vfs_default.c
> 
>    This makes it more clear that certain VFS-ops are giving default
>    behavior, either returning automatic success or returning EOPNOTSUPP.

I like the idea. (However, I think that the functions returning failure 
should not be called NOPs.)

> Why does VFS_CHECKEXP take a vnode and not a mount point? 
> Hopefully in the future a filesystem will be able to more 
> restrictively export its files, this will help facilitate that.

IMO, if it take a vnode, it should be VOP_CHECKEXP, not VFS_CHECKEXP.

Dima




To Unsubscribe: send mail to majord...@freebsd.org
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to