On Tue, Feb 04, 2014 at 12:16:04PM +0200, Taras Korenko wrote: > Good morning, doc@ folks. > > The following notes were made while working on russian translation > of kernelconfig chapter. I hope some parts of the following diff > might be useful. > > So, could anyone review that diff?
Hi, see my 2c inline. > Index: en_US.ISO8859-1/books/handbook/kernelconfig/chapter.xml > =================================================================== > --- en_US.ISO8859-1/books/handbook/kernelconfig/chapter.xml (revision 43745) > +++ en_US.ISO8859-1/books/handbook/kernelconfig/chapter.xml (working copy) > @@ -204,8 +204,8 @@ > &man.pciconf.8;, which provides more verbose output. For > example:</para> > > - <programlisting><command>pciconf -lv</command> > - ath0@pci0:3:0:0: class=0x020000 card=0x058a1014 chip=0x1014168c > rev=0x01 hdr=0x00 > + <programlisting>&prompt.user; pciconf -lv > +ath0@pci0:3:0:0: class=0x020000 card=0x058a1014 chip=0x1014168c > rev=0x01 hdr=0x00 > vendor = 'Atheros Communications Inc.' > device = 'AR5212 Atheros AR5212 802.11abg wireless' > class = network > @@ -226,7 +226,7 @@ > ath_hal(4) - Atheros Hardware Access Layer > (HAL)</programlisting> > > <para>Once the hardware inventory list is created, refer to it > - to ensure that installed hardware is not removed as you edit the custom > + to ensure that drivers for installed hardware are not removed as you > edit the custom Or rather "drivers OR installed hardware"? :) Both may be removed I guess. > kernel configuration file.</para> > </sect1> > > @@ -250,11 +250,7 @@ > <para>If <filename>/usr/src/</filename> does > not exist or it is empty, source has not been installed. > Source can be installed using > - <application>svn</application>, which is described in <xref > linkend="svn"/>, or by installing the > - <literal>src</literal> distribution using &man.sysinstall.8;. This > - distribution can be selected by navigating to the > - <literal>Configuration</literal> and then to the > - <literal>Distributions</literal> menu within &man.sysinstall.8;.</para> > + <application>svn</application>, which is described in <xref > linkend="svn"/>.</para> You removed reference to sysinstall, but it is still in use in 9.x and 8.x (well ok, only in 8.x but it also exists in 9.x). If you want to touch this place, I would suggest to specify &os; version this is applicable for and briefly mention bsdinstall with referring to <xref linked="bsdinstall-components"/>. It would be fine with simply removing sysinstall part, but this leaves the reader without options. The rest looks good to me, given that you will split the changes into markup and content changes :).
pgpq9I86O4K66.pgp
Description: PGP signature
