On 29-Oct-2002 Joe Marcus Clarke wrote: > On Mon, 2002-10-28 at 16:37, John Baldwin wrote: >> >> On 28-Oct-2002 Joe Marcus Clarke wrote: >> > On Mon, 2002-10-28 at 16:27, John Baldwin wrote: >> >> >> >> On 28-Oct-2002 Terry Lambert wrote: >> >> > John Baldwin wrote: >> >> >> I mean, do you know what libgtop is used for? It's used to draw >> >> >> little applets that display load averages and other silly system >> >> >> monitor stuff in small spaces in GUI's. It seems to work quite >> >> >> happily w/o any inode numbers or dev_t's for non-UFS filesystems. >> >> >> I just don't see why some little graphical applet displaying a load >> >> >> average or disk usage or ethernet device usage needs the inode >> >> >> number and dev_t of vnode's in the kernel. I mean, geez. >> >> > >> >> > To build little applets that activate a flashing red light when >> >> > certain files are written? >> >> >> >> Why do you need the inode number to do that. Just kqueue on the >> >> file itself using a regular fd, and in that case you can stat(2) >> >> the file if you really need the i-node number. You don't need >> >> to use libkvm to actually go read the kernel to find this info! >> > >> > You're probably right. But without waiting to re-architect libgtop, I >> > think the immediate problem needs to be fixed. Shall I just commit my >> > original patch that uses libkvm? >> >> Use v_cachedid and v_cachedfs for all VREG vnodes. Then you don't >> need to even go near v_tag. This is fewer kvm_read()'s. If stable >> has the v_cachedid then it should be using that instead of reading >> in UFS inodes as well. > > This look okay?
Yep, thanks. :) -- John Baldwin <[EMAIL PROTECTED]> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
