On 29-Mar-01 Jesper Skriver wrote:
> On Thu, Mar 29, 2001 at 01:13:09PM -0800, John Baldwin wrote:
>> >
>> > Index: src/sys/dev/pccbb/pccbb.c
>> > ===================================================================
>> > RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
>> > retrieving revision 1.12
>> > diff -u -r1.12 pccbb.c
>> > --- src/sys/dev/pccbb/pccbb.c 2001/02/09 06:08:52 1.12
>> > +++ src/sys/dev/pccbb/pccbb.c 2001/03/28 20:51:20
>> > @@ -53,6 +53,8 @@
>> > #include <sys/kernel.h>
>> > #include <sys/kthread.h>
>> > #include <sys/malloc.h>
>> > +#include <sys/types.h>
>> > +#include <sys/lock.h>
>> > #include <sys/mutex.h>
>> >
>> > #include <sys/bus.h>
>>
>> Please sort the includes or at least attempt to as that is style(9). You'll
>> need to mvoe lock.h up before malloc.h. types.h is special, it belongs as
>> the
>> very first header unless sys/param.h is the first header (param.h includes
>> types.h).
>
> The above was committed, so would the below fix it right ?
>
> Index: src/sys/dev/pccbb/pccbb.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
> retrieving revision 1.13
> diff -u -r1.13 pccbb.c
> --- src/sys/dev/pccbb/pccbb.c 2001/03/29 10:23:45 1.13
> +++ src/sys/dev/pccbb/pccbb.c 2001/03/29 22:06:51
> @@ -52,9 +52,8 @@
> #include <sys/errno.h>
> #include <sys/kernel.h>
> #include <sys/kthread.h>
> -#include <sys/malloc.h>
> -#include <sys/types.h>
> #include <sys/lock.h>
> +#include <sys/malloc.h>
> #include <sys/mutex.h>
>
> #include <sys/bus.h>
Sure, as long as it compiles. :)
--
John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
