On Thu, Mar 29, 2001 at 01:13:09PM -0800, John Baldwin wrote:
> >
> > Index: src/sys/dev/pccbb/pccbb.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
> > retrieving revision 1.12
> > diff -u -r1.12 pccbb.c
> > --- src/sys/dev/pccbb/pccbb.c 2001/02/09 06:08:52 1.12
> > +++ src/sys/dev/pccbb/pccbb.c 2001/03/28 20:51:20
> > @@ -53,6 +53,8 @@
> > #include <sys/kernel.h>
> > #include <sys/kthread.h>
> > #include <sys/malloc.h>
> > +#include <sys/types.h>
> > +#include <sys/lock.h>
> > #include <sys/mutex.h>
> >
> > #include <sys/bus.h>
>
> Please sort the includes or at least attempt to as that is style(9). You'll
> need to mvoe lock.h up before malloc.h. types.h is special, it belongs as the
> very first header unless sys/param.h is the first header (param.h includes
> types.h).
The above was committed, so would the below fix it right ?
Index: src/sys/dev/pccbb/pccbb.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/pccbb/pccbb.c,v
retrieving revision 1.13
diff -u -r1.13 pccbb.c
--- src/sys/dev/pccbb/pccbb.c 2001/03/29 10:23:45 1.13
+++ src/sys/dev/pccbb/pccbb.c 2001/03/29 22:06:51
@@ -52,9 +52,8 @@
#include <sys/errno.h>
#include <sys/kernel.h>
#include <sys/kthread.h>
-#include <sys/malloc.h>
-#include <sys/types.h>
#include <sys/lock.h>
+#include <sys/malloc.h>
#include <sys/mutex.h>
#include <sys/bus.h>
/Jesper
--
Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456
Work: Network manager @ AS3292 (Tele Danmark DataNetworks)
Private: FreeBSD committer @ AS2109 (A much smaller network ;-)
One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone to bind them.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
