On Tue, Nov 28, 2000 at 02:57:45PM -0700, Warner Losh wrote:
> In message <[EMAIL PROTECTED]> Kris Kennaway writes:
> : Please review. This syncs up our code with some NetBSD changes, as well
> : as attempting to sync rwall up with wall.
>
> You might also want to bruing in the openBSD changes for wall -g.
I thought that was your project ;-)
> Plus a few nits:
> + char *tty, hostname[MAXHOSTNAMELEN], lbuf[256], tmpname[64];
>
> tmpname should be tmpname[MAXPATHLEN] since it is a path. Note well,
> not MAXPATHLEN + 1 since MAXPATHLEN is defined to include the trailing
> NUL (I have patches in my tree that fix this for the rest of the tree,
> at least the +1 issue, other issues will have to wait until I can
> audit all strings passed to open, mktemp, et al).
Yeah..I pondered doing that, but it's used to store a
#define'd string so I didn't worry about it too much. Since I'm out of
touch, feel free to do this yourself before I get back.
Kris
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
