In message <[EMAIL PROTECTED]> Kris Kennaway writes:
: Please review. This syncs up our code with some NetBSD changes, as well
: as attempting to sync rwall up with wall.

You might also want to bruing in the openBSD changes for wall -g.

Plus a few nits:
+       char *tty, hostname[MAXHOSTNAMELEN], lbuf[256], tmpname[64];

tmpname should be tmpname[MAXPATHLEN] since it is a path.  Note well,
not MAXPATHLEN + 1 since MAXPATHLEN is defined to include the trailing
NUL (I have patches in my tree that fix this for the rest of the tree,
at least the +1 issue, other issues will have to wait until I can
audit all strings passed to open, mktemp, et al).

Warner


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to