Paul-Antoine Arras wrote:
On 16/02/2026 16:49, Tobias Burnus wrote:
LGTM – however, I think it would be good if at least one of the
testcases could be made a bit more through/robust:
Currently, only two elements are checked for being in order – I think
it would be better to check for a handful, added to the map clauses
in random order (and possibly skipping one or two).
The attached revised patch has an extended libgomp test
map-subarray-12.f90 that covers several of those more complex scenarios.
Additionally, it might help to add a comment like 'sort mapped
components by offset' in the 'if (has_descriptor)' block to make it
easier to follow that the code does.
Added comment as suggested. […]
Is it OK for trunk like this?
LGTM. Thanks!
But consider updating the AuthorDate (Tue, 2 Dec 2025) when committing;
I always find old dates confusing, especially if the patch has been
modified after the initial version. (I know that there is also
CommitDate, i.e. it is not a show stopper but still ...)
Tobias
