On Thu, 2025-06-26 at 17:45 +0000, Yuao Ma wrote: > Hi all, > > This patch, a follow-up to r16-1652-g0606d2b979f401, implements > middle-end > optimizations (e.g., constant folding) for our trigonometric pi-based > function > built-ins. > > This patch is part of > https://gcc.gnu.org/pipermail/fortran/attachments/20250607/4a4a9cb6/attachment.obj > > Please take a look when you are available. Thanks!
I'm not an expert on this part of the code, but I noticed that the code part of the patch has these guards: #if MPFR_VERSION >= MPFR_VERSION_NUM(4, 2, 0) but the testcases don't seem to be conditionalized on this. Would the new tests fail if gcc is built against an insufficiently recent version of mpfr, and is/should there be some kind of dg-requires for this, so that the new tests gracefully are "UNSUPPORTED" on such configurations? Hope this is constructive; sorry if I'm missing something here. Dave
