Hi FX,
the patch looks good to me. I only have x86_64, too, therefore I haven't tested
it (again). There's a lot of repetition in the regenerate.sh file. I hope to
see this "simplified" or rather DRY'ed (Don't repeat yourself - principle) in
the future.
So looks good to me. Ok for mainline.
Regards,
Andre
On Mon, 9 Jun 2025 21:06:02 +0200
FX Coudert <fxcoud...@gmail.com> wrote:
> Hi,
>
> This patch adds a new “regenerate.sh” script in libgfortran/, which is the
> new mechanism to rebuild all source files in the generated/ folder. It
> removes this from the Makefile (where it was misusing the maintainer mode,
> which was not intended for that purpose). The new script is standalone, and
> it should be run by developers whenever they modify a file in the m4/
> directory. It will not be triggered by the Makefile, and must be run
> manually. It does not modify the timestamps or inodes of generated files, if
> they are not be modified.
>
> The Makefile can later be simplified, but I don’t want to mix all the changes
> at once, so here’s a first part. If there is agreement, I’ll work on
> simplifying the Makefile next.
>
> Undergoing testing on x86_64-linux, OK to push?
> FX
>
>
--
Andre Vehreschild * Email: vehre ad gmx dot de
