On Sun, 6 Apr 2025 at 14:39, Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > > Hi All, > > As far as I can tell, the attached patch fixes the problems with the reduce > intrinsic. I would be grateful to the reporters if they would confirm that > this is the case. > > The key to the fix appears in reduce_3.f90, which failed even with -m64. > Although it was not apparent from the tree dump, the scalar result was going > on the stack. Once it became larger than the word size, it pushed the > arguments out of alignment with the library prototype. > > I took the opportunity to add character length checking to the library. I > think that it might be redundant and so might not appear in the submitted > version. Thus far, I have failed to trigger the errors because the frontend > seems to catch them all. reduce_c and reduce_scalar_c will look a lot neater > without them. > > Harald has been enormously helpful in hunting out remaining problems and > providing fixes. These are woven into the patch. > > Regtests on FC41/x86_64 - OK for mainline after confirmations from the > reporters? >
Hi! I've just verified that all gfortran.dg/reduce_*.f90 now pass on arm-unknown-linux-gnueabihf. Thanks, Christophe > Paul >
